kevinjqliu commented on issue #1708:
URL: 
https://github.com/apache/iceberg-python/issues/1708#issuecomment-2679044975

   This is great! I summarized the behavior in 
https://github.com/apache/iceberg-python/pull/1709#pullrequestreview-2637748112
   copy/pasting here:
   
   * When `s3.region` is set, use it to initialize the `S3FileSystem` 
(`s3.resolve-region` is `False` by default)
   * When `s3.region` is set and `s3.resolve-region` is `True`, resolve the 
region by calling `resolve_s3_region` and use the resolved region for 
`S3FileSystem`. If the resolved region is different than `s3.region`, emit a 
warning to the user.
   * When `s3.region` is not set and `s3.resolve-region` is `False` (default), 
use the `s3.region`'s `None` value for `S3FileSystem`. The `S3FileSystem` also 
does its own resolution.
   * When `s3.region` is not set and `s3.resolve-region` is `True`, resolve the 
region and use that for `S3FileSystem`, but do not emit a warning to user.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to