kevinjqliu commented on code in PR #1642:
URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1954915956
##########
pyiceberg/table/locations.py:
##########
@@ -64,6 +71,35 @@ def new_data_location(self, data_file_name: str,
partition_key: Optional[Partiti
str: A fully-qualified location URI for the data file.
"""
+ def new_table_metadata_file_location(self, new_version: int = 0) -> str:
Review Comment:
for 1, we haven't released a version with LocationProvider. so any
references going forward should also have the new methods. We probably want to
add a note in the [location provider
docs](https://github.com/apache/iceberg-python/blob/1c9f177be4bbb5a1bef78b46f69a1a3d56de427d/mkdocs/docs/configuration.md#location-providers)
about the new metadata location feature
> The way this is written makes me wonder whether users might want to
customise their metadata locations under a table instead of providing a
hard-coded path - in a similar way to custom LocationProviders do for data files
does "under a table" mean path relative to the table's base location? The
SimpleLocation Provider uses absolute path. The ObjectStoreLocationProvider is
special in that it injects some hash after the base location. But i think a
custom metadata location provider can do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
