kevinjqliu commented on code in PR #1642:
URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1955383770
##########
pyiceberg/table/locations.py:
##########
@@ -64,6 +71,35 @@ def new_data_location(self, data_file_name: str,
partition_key: Optional[Partiti
str: A fully-qualified location URI for the data file.
"""
+ def new_table_metadata_file_location(self, new_version: int = 0) -> str:
Review Comment:
this is interesting because for data file path, we can use
`TableProperties.WRITE_DATA_PATH` to override LocationProvider's
`self.data_path`, which is the prefix of the data file path.
And `new_data_location` to override the behavior of the fully-qualified data
file location.
We're trying recreate the same behavior for metadata path.
`TableProperties.WRITE_METADATA_PATH` to override the LocationProvider's
`self.metadata_path`, which is the prefix of the metadata file path.
And `new_metadata_location` to override the behavior of the fully-qualified
metadata file location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
