kevinjqliu commented on code in PR #1642:
URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1951696715
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -84,14 +84,14 @@
from pyiceberg.table import Transaction
-def _new_manifest_path(location: str, num: int, commit_uuid: uuid.UUID) -> str:
- return f"{location}/metadata/{commit_uuid}-m{num}.avro"
+def _new_manifest_file_name(num: int, commit_uuid: uuid.UUID) -> str:
+ return f"{commit_uuid}-m{num}.avro"
-def _generate_manifest_list_path(location: str, snapshot_id: int, attempt:
int, commit_uuid: uuid.UUID) -> str:
+def _generate_manifest_list_file_name(snapshot_id: int, attempt: int,
commit_uuid: uuid.UUID) -> str:
Review Comment:
nit: similar naming scheme as the functino above
```suggestion
def _new_manifest_list_file_name(snapshot_id: int, attempt: int,
commit_uuid: uuid.UUID) -> str:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
