Fokko commented on code in PR #1642:
URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1953202171
##########
pyiceberg/catalog/__init__.py:
##########
@@ -929,11 +931,12 @@ def _write_metadata(metadata: TableMetadata, io: FileIO,
metadata_path: str) ->
ToOutputFile.table_metadata(metadata, io.new_output(metadata_path))
@staticmethod
- def _get_metadata_location(location: str, new_version: int = 0) -> str:
+ def _get_metadata_location(table_location: str, new_version: int = 0,
properties: Properties = EMPTY_DICT) -> str:
Review Comment:
My first idea would be to make this part of the `LocationProvider`. Any
thoughts on that? @geruh @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
