rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1953613226
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -788,6 +792,9 @@ public static <T> T visit(Type type,
CustomOrderSchemaVisitor<T> visitor) {
new VisitFuture<>(map.keyType(), visitor),
new VisitFuture<>(map.valueType(), visitor));
+ case VARIANT:
+ return visitor.variant();
Review Comment:
I'm debating whether this should pass the type. If we want to do it later,
that would be an added method. When returning types, it's a good idea to pass
the original instance, rather than assuming that it is identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
