aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1946870340
##########
core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java:
##########
@@ -56,6 +56,10 @@ class BuildAvroProjection extends
AvroCustomOrderSchemaVisitor<Schema, Schema.Fi
@Override
@SuppressWarnings("checkstyle:CyclomaticComplexity")
public Schema record(Schema record, List<String> names,
Iterable<Schema.Field> schemaIterable) {
+ if (current.isVariantType()) {
Review Comment:
You mean handle variant in the following visit method? As I mentioned that
we don't have variant logical type in Schema.getType() from avro, we can't
handle that for now. Let me know if understand correctly. I think this is
needed for metadata change and I can defer until then.
> abstract class AvroCustomOrderSchemaVisitor<T, F> {
> public static <T, F> T visit(Schema schema,
AvroCustomOrderSchemaVisitor<T, F> visitor) {
> switch (schema.getType()) {
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
