rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1942103932
##########
data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java:
##########
@@ -76,4 +86,29 @@ protected void writeAndValidate(Schema writeSchema, Schema
expectedSchema) throw
protected boolean supportsDefaultValues() {
return true;
}
+
+ @Test
+ public void testSchemaWithTwoVariants() throws JsonProcessingException {
Review Comment:
Why is this test in `TestGenericData`? It looks like this is testing the
output of `convert(schema, "table")` but passing the schema through
`GenericData.Record` and a `GenericRecordBuilder` first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
