rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1953612580
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -81,6 +82,15 @@ public static PrimitiveType fromPrimitiveString(String
typeString) {
throw new IllegalArgumentException("Cannot parse type string to primitive:
" + typeString);
}
+ public static PrimitiveType fromPrimitiveString(String typeString) {
+ Type type = fromTypeName(typeString);
+ if (type.isPrimitiveType()) {
+ return (PrimitiveType) type;
Review Comment:
Nit: should use `asPrimitiveType()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
