rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1942096627
##########
core/src/test/java/org/apache/iceberg/TestSchemaUnionByFieldName.java:
##########
@@ -75,7 +75,7 @@ private static NestedField[] primitiveFields(
optional(
atomicInteger.incrementAndGet(),
type.toString(),
- Types.fromPrimitiveString(type.toString())))
+ Types.fromTypeString(type.toString())))
Review Comment:
It looks like this is correct, but do you want to add `VariantType.get()` to
the list of types that are tested as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
