Fokko commented on code in PR #12211:
URL: https://github.com/apache/iceberg/pull/12211#discussion_r1950769476
##########
api/src/main/java/org/apache/iceberg/UpdateSchema.java:
##########
@@ -169,13 +239,41 @@ default UpdateSchema addRequiredColumn(String name, Type
type) {
* @return this for method chaining
* @throws IllegalArgumentException If name contains "."
*/
- UpdateSchema addRequiredColumn(String name, Type type, String doc);
+ default UpdateSchema addRequiredColumn(String name, Type type, String doc) {
+ return addRequiredColumn(name, type, doc, null);
+ }
/**
* Add a new required top-level column.
*
- * <p>This is an incompatible change that can break reading older data. This
method will result in
- * an exception unless {@link #allowIncompatibleChanges()} has been called.
+ * <p>Because "." may be interpreted as a column path separator or may be
used in field names, it
+ * is not allowed in names passed to this method. To add to nested
structures or to add fields
+ * with names that contain ".", use {@link #addRequiredColumn(String,
String, Type)}.
+ *
+ * <p>If type is a nested type, its field IDs are reassigned when added to
the existing schema.
+ *
+ * @param name name for the new column
+ * @param type type for the new column
+ * @param doc documentation string for the new column
+ * @return this for method chaining
Review Comment:
Missing Jdoc for `defaultValue`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
