rdblue commented on code in PR #12211:
URL: https://github.com/apache/iceberg/pull/12211#discussion_r1948233106
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -55,7 +56,7 @@ class SchemaUpdate implements UpdateSchema {
private final Map<Integer, Integer> idToParent;
private final List<Integer> deletes = Lists.newArrayList();
private final Map<Integer, Types.NestedField> updates = Maps.newHashMap();
- private final Multimap<Integer, Types.NestedField> adds =
+ private final Multimap<Integer, Integer> parentToAddedIds =
Review Comment:
Added fields are now tracked in `updates` so that the added fields can be
updated in the same set of schema changes. Now this multi-map tracks the fields
added to a parent struct by ID rather than keeping a list of unchangeable
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
