rdblue commented on code in PR #12211:
URL: https://github.com/apache/iceberg/pull/12211#discussion_r1948232917
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -559,15 +559,22 @@ public static Builder optional(String name) {
return new Builder(true, name);
}
+ public static Builder builder() {
+ return new Builder();
+ }
+
public static class Builder {
- private final boolean isOptional;
- private final String name;
+ private boolean isOptional = true;
+ private String name = null;
Review Comment:
These changes enable the builder to handle all updates, even to whether the
field is optional and the field name. That way the builder is always used to
copy instead of needing to support specific fields when changing the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
