rdblue commented on code in PR #12211:
URL: https://github.com/apache/iceberg/pull/12211#discussion_r1948233225
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -94,40 +95,24 @@ public SchemaUpdate allowIncompatibleChanges() {
}
@Override
- public UpdateSchema addColumn(String name, Type type, String doc) {
- Preconditions.checkArgument(
- !name.contains("."),
- "Cannot add column with ambiguous name: %s, use addColumn(parent,
name, type)",
- name);
- return addColumn(null, name, type, doc);
- }
-
- @Override
- public UpdateSchema addColumn(String parent, String name, Type type, String
doc) {
- internalAddColumn(parent, name, true, type, doc);
- return this;
- }
-
- @Override
- public UpdateSchema addRequiredColumn(String name, Type type, String doc) {
Review Comment:
Moved into the interface as a default implementation.
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -94,40 +95,24 @@ public SchemaUpdate allowIncompatibleChanges() {
}
@Override
- public UpdateSchema addColumn(String name, Type type, String doc) {
Review Comment:
Moved into the interface as a default implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
