Fokko commented on code in PR #12211:
URL: https://github.com/apache/iceberg/pull/12211#discussion_r1950756477
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -583,6 +589,26 @@ private Builder(NestedField toCopy) {
this.writeDefault = toCopy.writeDefault;
}
+ public Builder asRequired() {
+ this.isOptional = false;
+ return this;
+ }
+
+ public Builder asOptional() {
+ this.isOptional = true;
+ return this;
+ }
+
+ public Builder isOptional(boolean fieldIsOptional) {
+ this.isOptional = fieldIsOptional;
+ return this;
+ }
+
+ public Builder withName(String fieldName) {
+ this.name = fieldName;
Review Comment:
We check for not-null at 660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
