RussellSpitzer commented on code in PR #12060: URL: https://github.com/apache/iceberg/pull/12060#discussion_r1927414041
########## core/src/main/java/org/apache/iceberg/InternalData.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.IOException; +import java.util.Map; +import java.util.function.Function; +import org.apache.iceberg.avro.Avro; +import org.apache.iceberg.common.DynMethods; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.FileAppender; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class InternalData { + private InternalData() {} + + private static final Logger LOG = LoggerFactory.getLogger(InternalData.class); + private static final Map<FileFormat, Function<OutputFile, WriteBuilder>> WRITE_BUILDERS = + Maps.newConcurrentMap(); + private static final Map<FileFormat, Function<InputFile, ReadBuilder>> READ_BUILDERS = + Maps.newConcurrentMap(); + + static { + Avro.register(); + + try { + DynMethods.StaticMethod registerParquet = + DynMethods.builder("register") + .impl("org.apache.iceberg.parquet.Parquet") + .buildStaticChecked(); + + registerParquet.invoke(); + + } catch (NoSuchMethodException e) { + // failing to load Parquet is normal and does not require a stack trace + LOG.info("Unable to register Parquet for metadata files: {}", e.getMessage()); + } + } + + public static void register( + FileFormat format, + Function<OutputFile, WriteBuilder> writeBuilder, + Function<InputFile, ReadBuilder> readBuilder) { + WRITE_BUILDERS.put(format, writeBuilder); + READ_BUILDERS.put(format, readBuilder); + } + + public static WriteBuilder write(FileFormat format, OutputFile file) { + Function<OutputFile, WriteBuilder> writeBuilder = WRITE_BUILDERS.get(format); + if (writeBuilder != null) { + return writeBuilder.apply(file); + } + + throw new UnsupportedOperationException( Review Comment: nit: Personally I think it may be a bit clearer to extract the handling the missing writer/reader maybe have ```java writerFor(File format) { writer = WRITE_BUILDERS.get(format) if (writer == null) { throw new Unsupported Exception } else { return writer; } } ``` So that this code is just ```java return writerFor(format).apply(file) ``` Mostly I feel a little unease about the implicit else in the current logic so having an `else` would also make me feel a little better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
