rdblue commented on code in PR #12060: URL: https://github.com/apache/iceberg/pull/12060#discussion_r1926212266
########## core/src/main/java/org/apache/iceberg/avro/InternalReader.java: ########## @@ -76,6 +76,15 @@ public void setSchema(Schema schema) { initReader(); } + @Override + public void setCustomTypes( Review Comment: Because the `InternalReader` is no longer created by `ManifestReader`, the custom types now need to be passed to the read builder and forwarded to the reader here. Custom type support will need to be implemented for Parquet as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org