rdblue commented on code in PR #12060: URL: https://github.com/apache/iceberg/pull/12060#discussion_r1926214256
########## core/src/main/java/org/apache/iceberg/avro/SupportsCustomRecords.java: ########## @@ -20,7 +20,7 @@ import java.util.Map; -/** An interface for Avro DatumReaders to support custom record classes. */ +/** An interface for Avro DatumReaders to support custom record classes by name. */ Review Comment: This is used to distinguish between Iceberg custom types that used field IDs and `StructLike` and Avro's, which worked by renaming Avro records to class names that would be dynamically loaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
