danielcweeks commented on code in PR #12060:
URL: https://github.com/apache/iceberg/pull/12060#discussion_r1927393190


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -125,6 +126,18 @@ public class Parquet {
 
   private Parquet() {}
 
+  public static void register() {
+    InternalData.register(FileFormat.PARQUET, Parquet::writeInternal, 
Parquet::readInternal);

Review Comment:
   We should move this up into the InternalData initialization.  I think we 
want to explicitly register, not rely on self registration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to