RussellSpitzer commented on code in PR #12060:
URL: https://github.com/apache/iceberg/pull/12060#discussion_r1927443891
##########
core/src/main/java/org/apache/iceberg/V1Metadata.java:
##########
@@ -330,32 +333,44 @@ public ManifestEntry<DataFile> copyWithoutStats() {
}
}
- static class IndexedDataFile implements DataFile, IndexedRecord {
+ static class DataFileWrapper implements DataFile, StructLike {
private static final long DEFAULT_BLOCK_SIZE = 64 * 1024 * 1024;
- private final org.apache.avro.Schema avroSchema;
- private final IndexedStructLike partitionWrapper;
+ private final int size;
private DataFile wrapped = null;
- IndexedDataFile(org.apache.avro.Schema avroSchema) {
- this.avroSchema = avroSchema;
- this.partitionWrapper = new
IndexedStructLike(avroSchema.getField("partition").schema());
Review Comment:
Big fan of this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
