rdblue commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1925925464
########## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java: ########## @@ -50,6 +54,32 @@ protected ParquetValueWriter<T> createWriter(MessageType type) { protected abstract ParquetValueWriters.StructWriter<T> createStructWriter( List<ParquetValueWriter<?>> writers); + protected ParquetValueWriter<?> fixedWriter(ColumnDescriptor desc) { + return new FixedWriter(desc); + } + + protected ParquetValueWriters.PrimitiveWriter<?> dateWriter(ColumnDescriptor desc) { Review Comment: Returning the right type (in this case, the interface) is a good thing. It's worth refactoring the private visitor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org