ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1926270438
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -850,4 +919,42 @@ private TripleIterator<?>
firstNonNullColumn(List<TripleIterator<?>> columns) {
return NullReader.NULL_COLUMN;
}
}
+
+ private static class RecordReader<T extends StructLike> extends
StructReader<T, T> {
Review Comment:
Internal readers expects `ParquetValueReader<StructLike>` and generic reader
expects `ParquetValueReader<Record>`, even though the `Record` extends
`StructLike`, because of java generics, we need to return the specific type
here. We cannot cast `ParquetValueReader<Record>` to
`ParquetValueReader<StructLike>`.
Hence, this was refactored. Similar to the writer refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
