ajantha-bhat commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1926371943
########## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java: ########## @@ -50,6 +46,31 @@ protected ParquetValueWriter<T> createWriter(MessageType type) { protected abstract ParquetValueWriters.StructWriter<T> createStructWriter( List<ParquetValueWriter<?>> writers); + protected ParquetValueWriter<?> fixedWriter(ColumnDescriptor desc) { + return new GenericParquetWriter.FixedWriter(desc); + } + + protected ParquetValueWriter<?> dateWriter(ColumnDescriptor desc) { + return new GenericParquetWriter.DateWriter(desc); + } + + protected ParquetValueWriter<?> timeWriter(ColumnDescriptor desc) { + return new GenericParquetWriter.TimeWriter(desc); + } + + protected ParquetValueWriter<?> timestampWriter(ColumnDescriptor desc, boolean isAdjustedToUTC) { + if (isAdjustedToUTC) { + return new GenericParquetWriter.TimestamptzWriter(desc); + } else { + return new GenericParquetWriter.TimestampWriter(desc); + } + } + + protected ParquetValueWriter<?> uuidWriter(ColumnDescriptor desc) { + // Use primitive-type writer (as FIXED_LEN_BYTE_ARRAY); no special writer needed. + return null; Review Comment: Sorry, the existing testcases was the reason for confusion as I mentioned in https://github.com/apache/iceberg/pull/11904#discussion_r1926274339 I will update the existing testcases of Arrow too in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org