rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1925907570
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##########
@@ -190,33 +210,49 @@ public Optional<ParquetValueWriters.PrimitiveWriter<?>>
visit(
}
@Override
- public Optional<ParquetValueWriters.PrimitiveWriter<?>> visit(
+ public Optional<ParquetValueWriter<?>> visit(
LogicalTypeAnnotation.DateLogicalTypeAnnotation dateType) {
- return Optional.of(new DateWriter(desc));
+ ParquetValueWriter<?> dateWriter = dateWriter(desc);
+ if (dateWriter != null) {
Review Comment:
There is no need to handle nulls here. A writer should always be returned by
the factory methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
