ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1926274339
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##########
@@ -50,6 +54,32 @@ protected ParquetValueWriter<T> createWriter(MessageType
type) {
protected abstract ParquetValueWriters.StructWriter<T> createStructWriter(
List<ParquetValueWriter<?>> writers);
+ protected ParquetValueWriter<?> fixedWriter(ColumnDescriptor desc) {
+ return new FixedWriter(desc);
+ }
+
+ protected ParquetValueWriters.PrimitiveWriter<?> dateWriter(ColumnDescriptor
desc) {
+ return new DateWriter(desc);
+ }
+
+ protected ParquetValueWriters.PrimitiveWriter<?> timeWriter(ColumnDescriptor
desc) {
+ return new TimeWriter(desc);
+ }
+
+ protected ParquetValueWriters.PrimitiveWriter<?> timestampWriter(
+ ColumnDescriptor desc, boolean isAdjustedToUTC) {
+ if (isAdjustedToUTC) {
+ return new TimestamptzWriter(desc);
+ } else {
+ return new TimestampWriter(desc);
+ }
+ }
+
+ protected ParquetValueWriters.PrimitiveWriter<?> uuidWriter(ColumnDescriptor
desc) {
+ // Use primitive-type writer; no special writer needed.
Review Comment:
All the generic reader writer test case uses UUID as byte[], hence it is
working.
You mean existing testcases are wrong?
https://github.com/apache/iceberg/blob/be6e9daf8901cdee63197e77fcf95624bb694f39/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java#L861-L862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
