RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1919348575
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -262,6 +265,8 @@ public String toString() {
private volatile Map<Long, Snapshot> snapshotsById;
private volatile Map<String, SnapshotRef> refs;
private volatile boolean snapshotsLoaded;
+ private final Boolean rowLineageEnabled;
Review Comment:
Let me double check, currently the issue is I don't want to add a
row-lineage = false field to a file that hasn't set row-lineage. I guess we
don't really care about that though so maybe I should just use the boolean here.
Basically the question is do we want 3 states
1) No row-lineage field
2) row-lineage = false
3) row-lineage = true
Or just 2
1) row-lineage = false
2) row-lineage = true
I can do the second option there, but then I think I should be omitting the
field for V2 and V1 tables? I am not sure what our prior art is on this so I'll
have to check ... My guiding principal here was to not write in the field at
all if it's not explicitly mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
