RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1920826065
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -262,6 +265,8 @@ public String toString() {
private volatile Map<Long, Snapshot> snapshotsById;
private volatile Map<String, SnapshotRef> refs;
private volatile boolean snapshotsLoaded;
+ private final Boolean rowLineageEnabled;
Review Comment:
I think it may be easier to just leave null as an option rather than special
casing write behavior in case of Versions 1 or 2. I think we've noted
previously we want to be strict in what we write so I want to be sure we aren't
writing down fields that aren't valid for older table versions and I think this
is the easiest route to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
