nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917881876
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -61,7 +63,9 @@ class BaseSnapshot implements Snapshot {
String operation,
Map<String, String> summary,
Integer schemaId,
- String manifestList) {
+ String manifestList,
+ Long firstRowId,
+ Long addedRows) {
Review Comment:
I guess one alternative could be to introduce a Snapshot Builder instead of
relying on the constructor. But if we decide to do that, I'd add that builder
to the core module rather than the test module (as is being done by #11947).
It would be good to get some other opinions here in order to decide what the
best path forward is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
