nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917915477


##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -360,6 +360,8 @@ public void testAddSnapshotToJson() throws IOException {
     long parentId = 1;
     long snapshotId = 2;
     int schemaId = 3;
+    Long firstRowId = 4L;
+    Long addedRows = 10L;

Review Comment:
   can you add a separate test to this test class for the new metadata update 
that is being introduced?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to