RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1919346303
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -615,10 +638,15 @@ public TableMetadata replaceProperties(Map<String,
String> rawProperties) {
int newFormatVersion =
PropertyUtil.propertyAsInt(rawProperties,
TableProperties.FORMAT_VERSION, formatVersion);
+ Boolean newRowLineage =
Review Comment:
This can be null if it's not in the properties and this would indicate that
the user isn't changing row-lineage or set it via a non-table-properties route.
In that case we have to leave the value the same in table metadata.
So three options in this spot
1. row-lineage is not set (do nothing) : null
2. row-lineage is set to false : Do nothing if we are already false, fail if
row-lineage is enabled
3. row-lineage is set to true : enableRow lineage if it isn't already enabled
I currently put all that logic in the helper function setRowLineageEnabled
which I kept private since it's only used by this location. I could just inline
that all here though if that is clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
