HonahX commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1916016403
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -314,31 +328,43 @@ public void testBackwardCompat() throws Exception {
assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull();
}
- @Test
- public void testInvalidMainBranch() throws IOException {
+ @ParameterizedTest
+ @MethodSource("formatVersionsProvider")
+ public void testInvalidMainBranch(int formatVersion) throws IOException {
+ assumeThat(formatVersion).isGreaterThanOrEqualTo(2);
Review Comment:
I added
```
static final int BRANCHING_MIN_SUPPORT_VERSION = 2;
static final int UUID_REQUIRED_MIN_VERSION = 2;
```
Do you think we need constants for other cases like
https://github.com/apache/iceberg/blob/34c480af42684a62e4a203161c1a935426e20329/core/src/test/java/org/apache/iceberg/TestTableMetadata.java#L719-L748
My concern is that if we do so we will end up with lots of constant for all
the new features starting from v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
