RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917405165
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -160,31 +155,16 @@ public void testJsonConversion() throws Exception {
.build());
TableMetadata expected =
- new TableMetadata(
- null,
- 2,
- UUID.randomUUID().toString(),
- TEST_LOCATION,
- SEQ_NO,
- System.currentTimeMillis(),
- 3,
- 7,
- ImmutableList.of(TEST_SCHEMA, schema),
- 5,
- ImmutableList.of(SPEC_5),
- SPEC_5.lastAssignedFieldId(),
- 3,
- ImmutableList.of(SORT_ORDER_3),
- ImmutableMap.of("property", "value"),
- currentSnapshotId,
- Arrays.asList(previousSnapshot, currentSnapshot),
- null,
- snapshotLog,
- ImmutableList.of(),
- refs,
- statisticsFiles,
- partitionStatisticsFiles,
- ImmutableList.of());
+
MetadataTestUtils.buildTestTableMetadataWithExampleValues(formatVersion)
+ .setCurrentSchemaId(7)
Review Comment:
we shouldn't really need any of these if they are in
TestTableMetadataWithExampleValues since this is a ser/de test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
