RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1915512319
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -96,31 +97,47 @@ public class TestTableMetadata {
public TableOperations ops = new LocalTableOperations(temp);
- @Test
+ private static Stream<Integer> formatVersionsProvider() {
+ return Stream.of(1, 2, 3);
+ }
+
+ @ParameterizedTest
+ @MethodSource("formatVersionsProvider")
Review Comment:
You can check my PR for this but we already have this in TestHelpers as a
field
```
@ParameterizedTest
@FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")
public void testAppendBranch(int formatVersion) {
```
Which hopefully makes it simpler next time for us to just update
ALL_VERSIONS in just one place and fix all the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
