RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1915513619
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -96,31 +97,47 @@ public class TestTableMetadata {
public TableOperations ops = new LocalTableOperations(temp);
- @Test
+ private static Stream<Integer> formatVersionsProvider() {
+ return Stream.of(1, 2, 3);
+ }
+
+ @ParameterizedTest
+ @MethodSource("formatVersionsProvider")
@SuppressWarnings("MethodLength")
- public void testJsonConversion() throws Exception {
+ public void testJsonConversion(int formatVersion) throws Exception {
Review Comment:
I'm not sure it's clear what this is testing anymore and why it is
restricted to 2 or higher? I think we may need to spend a little more time on
this one to be clear about what we are testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
