RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1915586726
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -314,31 +328,43 @@ public void testBackwardCompat() throws Exception {
assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull();
}
- @Test
- public void testInvalidMainBranch() throws IOException {
+ @ParameterizedTest
+ @MethodSource("formatVersionsProvider")
+ public void testInvalidMainBranch(int formatVersion) throws IOException {
+ assumeThat(formatVersion).isGreaterThanOrEqualTo(2);
Review Comment:
I feel like this should have a Constant in TableMetadata. I think we should
add in a BRANCHING_MIN_SUPPORT_VERSION or whatnot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
