rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1906140419
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java:
##########
@@ -38,6 +50,19 @@ protected StructWriter<Record>
createStructWriter(List<ParquetValueWriter<?>> wr
return new RecordWriter(writers);
}
+ @Override
+ protected LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<
+ ParquetValueWriters.PrimitiveWriter<?>>
+ logicalTypeWriterVisitor(ColumnDescriptor desc) {
+ return new LogicalTypeWriterVisitor(desc);
Review Comment:
Here, I would also prefer not to have subclasses provide the visitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
