paulcichonski commented on code in PR #1432:
URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1886987316
##########
pyiceberg/types.py:
##########
@@ -328,8 +328,8 @@ def __init__(
data["type"] = data["type"] if "type" in data else field_type
data["required"] = required
data["doc"] = doc
Review Comment:
I originally had that, but the tests seem to pass without it so I just kept
it as is. Happy to change if you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]