kevinjqliu commented on code in PR #1432:
URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1886982570


##########
pyiceberg/types.py:
##########
@@ -328,8 +328,8 @@ def __init__(
         data["type"] = data["type"] if "type" in data else field_type
         data["required"] = required
         data["doc"] = doc

Review Comment:
   curious if we should do the same here too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to