Fokko commented on code in PR #1432:
URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1888069247
##########
pyiceberg/types.py:
##########
@@ -328,8 +328,8 @@ def __init__(
data["type"] = data["type"] if "type" in data else field_type
data["required"] = required
data["doc"] = doc
Review Comment:
Yes, this is a bit messy, but it enables positional arguments. Otherwise,
you would always need to specify the keyword-arguments which is pretty verbose
:) If we decide to change this, that's fine, but probably in a separate PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
