singhpk234 commented on code in PR #11021: URL: https://github.com/apache/iceberg/pull/11021#discussion_r1813496517
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ########## @@ -297,7 +297,14 @@ private List<String> deleteBatch(String bucket, Collection<String> keysToDelete) @Override public Iterable<FileInfo> listPrefix(String prefix) { - S3URI s3uri = new S3URI(prefix, s3FileIOProperties.bucketToAccessPointMapping()); + S3URI temps3Uri = new S3URI(prefix, s3FileIOProperties.bucketToAccessPointMapping()); Review Comment: If we have accessPointMapping enabled wouldn't in the constructor itself we will change the `bucket` ? Should we not fail if the bucket is DirectoryBucket and we wanna have AccessPoint mapping enabled ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org