jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1813117694


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##########
@@ -115,4 +118,25 @@ public String scheme() {
   public String toString() {
     return location;
   }
+
+  public S3URI toDirectoryPath() {
+    if (key.endsWith(PATH_DELIM)) {
+      return new S3URI(location);
+    }
+    return new S3URI(location + PATH_DELIM);

Review Comment:
   oh sorry I thought we preserve `bucketToAccessPointMapping` in URI, but 
looks like it is not. then nvm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to