nastra commented on code in PR #11177:
URL: https://github.com/apache/iceberg/pull/11177#discussion_r1774870225
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -192,27 +185,43 @@ public static PositionDeleteIndex
toPositionIndex(CloseableIterable<Long> posDel
}
}
+ /**
+ * @deprecated since 1.7.0, will be removed in future.
+ */
+ @Deprecated
public static <T> CloseableIterable<T> streamingFilter(
CloseableIterable<T> rows,
Function<T, Long> rowToPosition,
CloseableIterable<Long> posDeletes) {
return streamingFilter(rows, rowToPosition, posDeletes, new
DeleteCounter());
}
+ /**
+ * @deprecated since 1.7.0, will be removed in future.
Review Comment:
```suggestion
* @deprecated since 1.7.0, will be removed in 1.8.0.
```
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -192,27 +185,43 @@ public static PositionDeleteIndex
toPositionIndex(CloseableIterable<Long> posDel
}
}
+ /**
+ * @deprecated since 1.7.0, will be removed in future.
+ */
+ @Deprecated
public static <T> CloseableIterable<T> streamingFilter(
CloseableIterable<T> rows,
Function<T, Long> rowToPosition,
CloseableIterable<Long> posDeletes) {
return streamingFilter(rows, rowToPosition, posDeletes, new
DeleteCounter());
}
+ /**
+ * @deprecated since 1.7.0, will be removed in future.
Review Comment:
same for the other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
