stevenzwu commented on code in PR #10965:
URL: https://github.com/apache/iceberg/pull/10965#discussion_r1725489331
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -70,6 +70,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
public static final String HADOOP_CONF_DIR = "hadoop-conf-dir";
public static final String DEFAULT_DATABASE = "default-database";
public static final String DEFAULT_DATABASE_NAME = "default";
+ public static final String DEFAULT_CATALOG_NAME = "default_catalog";
Review Comment:
> Accept the things as it is, and wait for 1.21 Flink release to solve the
issue,
didn't quite fully get this point.
> Backport the clean-up logic to Flink 1.18 branch
I would probably favor this. since it is not a big change and it is good to
minimize the difference btw versions.
`not dropping the current catalog` seems like a reasonable behavior to me,
although I am not opinionated on whether it should be allowed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
