stevenzwu commented on code in PR #10965:
URL: https://github.com/apache/iceberg/pull/10965#discussion_r1722564325
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestBase.java:
##########
@@ -122,7 +123,23 @@ protected void assertSameElements(String message,
Iterable<Row> expected, Iterab
* @param ifExists If we should use the 'IF EXISTS' when dropping the catalog
*/
protected void dropCatalog(String catalogName, boolean ifExists) {
- sql("USE CATALOG default_catalog");
+ sql("USE CATALOG %s", DEFAULT_CATALOG_NAME);
sql("DROP CATALOG %s %s", ifExists ? "IF EXISTS" : "", catalogName);
}
+
Review Comment:
this is a change introduced by 1.19. With the refactoring, this is needed
for 1.18 now.
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -70,6 +70,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
public static final String HADOOP_CONF_DIR = "hadoop-conf-dir";
public static final String DEFAULT_DATABASE = "default-database";
public static final String DEFAULT_DATABASE_NAME = "default";
+ public static final String DEFAULT_CATALOG_NAME = "default_catalog";
Review Comment:
this is a change introduced by 1.19 and used by `TestBas#dropDatabase`. With
the refactoring, this is needed for 1.18 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
