pvary commented on code in PR #10965:
URL: https://github.com/apache/iceberg/pull/10965#discussion_r1724446110
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -70,6 +70,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
public static final String HADOOP_CONF_DIR = "hadoop-conf-dir";
public static final String DEFAULT_DATABASE = "default-database";
public static final String DEFAULT_DATABASE_NAME = "default";
+ public static final String DEFAULT_CATALOG_NAME = "default_catalog";
Review Comment:
I would like to talk about the `dropCatalog` related test changes with you.
It was introduced by the 1.19 migration - there is a Flink change there
which prevents dropping the current catalog. At that time we introduced this
change to 1.19 only, and planned to create a better clean-up policy around the
tests (I think on another PR we already touched this topic).
This causes continuous "the backport is not clean, because..." issues.
Shall we:
- Accept the things as it is, and wait for 1.21 Flink release to solve the
issue, or
- Backport the clean-up logic to Flink 1.18 branch (even if it is not needed
there), or
- Do a generic cleanup in the Flink tests?
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
