pvary commented on code in PR #10965:
URL: https://github.com/apache/iceberg/pull/10965#discussion_r1726616704
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -70,6 +70,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
public static final String HADOOP_CONF_DIR = "hadoop-conf-dir";
public static final String DEFAULT_DATABASE = "default-database";
public static final String DEFAULT_DATABASE_NAME = "default";
+ public static final String DEFAULT_CATALOG_NAME = "default_catalog";
Review Comment:
In this PR: https://github.com/apache/iceberg/pull/10776 we decided
differently, and removed the `dropDatabase` calls from the 1.18
`TestIcebergSpeculativeExecutionSupport` tests.
I haven't find any other backports where the question was raised.
I think we should handle this consistently between the backports. If we
backport the `dropDatabase` here, then here in this PR, or in another PR we
need to make sure there are use in `TestIcebergSpeculativeExecutionSupport` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
