ndrluis commented on PR #10939: URL: https://github.com/apache/iceberg/pull/10939#issuecomment-2291278718
> Sorry, I don't get how git commit --fixup + git rebase + git force push helps to make things easier for reviewer to pick up from last review? I believe I may have caused some confusion. The problem with force pushing arises when someone fixes the requested changes using `--amend`. If the person uses a new commit, it’s not an issue. So, in my view, the recommendation should be to avoid using `--amend` for commits. Instead, create new commits with the suggested changes or use the fixup strategy. For me, a pull request with a lot of "fix" commits and merge commits is much harder to review. It’s better to review the whole PR rather than trying to understand each fix commit, and the merge commits are just unnecessary noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
