stevenzwu commented on code in PR #10939: URL: https://github.com/apache/iceberg/pull/10939#discussion_r1719050896
########## site/docs/contribute.md: ########## @@ -44,6 +44,7 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * It's helpful to include a prefix in the summary that provides context to PR reviewers, such as `Build:`, `Docs:`, `Spark:`, `Flink:`, `Core:`, `API:` * If a PR is related to an issue, adding `Closes #1234` in the PR description will automatically close the issue and helps keep the project clean * If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft +* If a PR is already under review, please avoid force-pushing to the branch as it can make it difficult for reviewers to track changes. If you need to keep the PR up-to-date with the main branch, consider merge rather than rebase Review Comment: > If you need to keep the PR up-to-date with the main branch, consider merge rather than rebase I have frequently used rebase and force push. from local branch, rebase is cleaner and easier to see the changes/commits in the PR source branch, as they are in the top. trying to understand the difference btw merge and rebase in this case. can you share a PR where merge is used? want to see how it affect the look of the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
