liurenjie1024 commented on PR #10939: URL: https://github.com/apache/iceberg/pull/10939#issuecomment-2290809213
> In my workflow, I prefer to use rebase instead of merge, and I often force-push. However, I utilize the [fixup commit](https://jordanelver.co.uk/blog/2020/06/04/fixing-commits-with-git-commit-fixup-and-git-rebase-autosquash/) to reference the specific past commit I'm modifying, which makes it easier for the reviewer and helps keep the git history cleaner. In the end, I can run a git rebase --autosquash, but since we use squash, this is not a problem. Sorry, I don't get how `git commit --fixup` + `git rebase` + `git force push` helps to make things easier for reviewer to pick up from last review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
