pvary commented on PR #10939: URL: https://github.com/apache/iceberg/pull/10939#issuecomment-2292839168
I also often use force push myself. The main cases being: 1. CI catches errors between reviews - immediate fix, and easier to review 2. Need to rebase on small upstream changes - if the rebase is trivial, then typically it doesn't need reviewer attention, if big, then a full review is needed. If there is an easy way to create reviewable merge commits, then the 2nd point could be avoided. Maybe adding a few example comments to the doc would help the developers. I still think that the first point is a valid use case for the force pushes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
